Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ended up being a little more involved than I expected..
__getitem__is left relatively intact for bothTinyGraphandEdgeProxy, but__setitem__needed to be modified for better error-handling (e.g. missing edges, poorly formatted requests). There's a weird edge case if you pass the same edge multiple times, but in opposite directions:I resolved this by reordering the vertex indices so that the first sequence always has the lower index, and this becomes equivalent to:
which might still be weird, but at least numpy handles it for us and we still have a symmetric adjacency matrix. An alternate solution would be to set the elements of the adjacency matrix elementwise, but that requires extra casework (sequence/list vs int).